Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#183 Ensure that having a rule where each field is the same w… #16155

Merged
merged 1 commit into from
Dec 28, 2019

Conversation

seamuslee001
Copy link
Contributor

…eight with the threshold being the total sum of the weights does not cause a fatal error when searching for dupes

Overview

This fixes a fatal error that Richard @magnolia61 found as per comment on #15826. I think the main difference here is that no dupes will have been found with the first 2 rules i think but not sure however when I put Richard's rule into a unit test it failed and this fixed the unit test

Before

DB error already exist can occur with the given rule

After

No DB error and dupes can be found

ping @eileenmcnaughton @totten @mattwire @magnolia61

@civibot
Copy link

civibot bot commented Dec 28, 2019

(Standard links)

…eight with the threshold being the total sum of the weights does not cause a fatal error when searching for dupes
@magnolia61
Copy link
Contributor

Just tested this patch and indeed I do not run into fatals anymore. Thanks!

@seamuslee001
Copy link
Contributor Author

I'm going to merge this based on @magnolia61 's review and given it fixes a possible fatal in the RC which is due out in only a couple of days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants