dev/core#1482 Remove lines of code that appear to relate to legacy logic

[eileenmcnaughton]

Overview

Removes some obsolete code, and, in doing so a query

Before

Entry in subscription_history created with no group_id on new contact create

After

Above removed

Technical Details

As discussed in https://lab.civicrm.org/dev/core/issues/1482 the subscription history table appears to still be used for
recording group history but this business of creating a row with no attached group appears to be from a logic flow that
is long-superceded by change log & db logging

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[artfulrobot]

• General standards
  • (r-explain) PASS
  • (r-user) PASS
  • (r-doc) PASS
  • (r-run) UNTESTED
• Developer standards
  • (r-tech) PASS
  • (r-code) PASS
  • (r-maint) PASS
  • (r-test) UNTESTED

This is as discussed; it removes code that does nothing useful and actually creates troublesome data rows in a table whose purpose is unrelated to creating a contact.

[yashodha]

@eileenmcnaughton makes sense, +1 for removing obsolete code