[NFC] If statement is always true

[demeritcowboy]

Overview

This line is always true. It uses boolean OR and has been that way since it was added 8 years ago.

   if ($config->userFramework != 'Joomla' ||
     $config->userFramework != 'WordPress'
   ) {

Before

TRUE

After

TRUE

Technical Details

To be super-picky, if userFramework was numeric 0 the line would be false, but userFramework shouldn't be numeric 0.

Comments

If you look at the diff ignoring whitespace it's easier to see the change. The rest is indentation.

While the line was likely intended to be boolean AND, the scope of this PR is just to remove a line that does nothing and has been doing nothing for 8 years. There is another related line but even when that is removed it doesn't make report permissions fully work for Joomla, likely because of yet more lines elsewhere. This PR doesn't address that.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[MegaphoneJon]

I haven't done an r-run of the code (can do so later today) but I reviewed the code and agree that @demeritcowboy is correct.

For a bonus cleanup - there's an ampersand on an object that can disappear too, but obviously not a blocker.

[demeritcowboy]

Thanks. Yes you're right that ampersand could go.

[demeritcowboy]

jenkins retest this please

[eileenmcnaughton]

I see @MegaphoneJon was going to r-run & didn't get back to it. I looked at the code & agree with the 2 of you that it is impossible for the IF to be true so I'm OK merging based our our 3 readings of the code - I'm a little unsure how we would r-run it tbh