Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1474 - (On Hold) text missing from email column when custom … #16101

Merged
merged 1 commit into from
Dec 17, 2019

Conversation

jitendrapurohit
Copy link
Contributor

…search profile is used in Advanced Search

Overview

Fix missing (on hold) text from advanced search

Before

To replicate

  • Create a search profile with an email field.
  • Use this profile to view Advanced Search results.

Eg - [email protected] email is (on hold) on the contact -

image

but is not specified in Advanced Search results -

image

After

On Hold is displayed in the Advanced Search results -

image

Technical Details

This was handled for normal search profile used in Advanced search. Extended it to also display it under custom search profile.

Comments

Gitlab - https://lab.civicrm.org/dev/core/issues/1474

Added unit test.

@civibot
Copy link

civibot bot commented Dec 13, 2019

(Standard links)

@civibot civibot bot added the master label Dec 13, 2019
@yashodha
Copy link
Contributor

@jitendrapurohit It looks like there are some style issues. Can you please fix
https://test.civicrm.org/job/CiviCRM-Core-PR/31110/checkstyleResult/new/

…search profile is used in Advanced Search

Add test
@jitendrapurohit
Copy link
Contributor Author

Style warnings fixed. Thanks @yashodha

@yashodha
Copy link
Contributor

@jitendrapurohit tested this, works well.

@yashodha yashodha merged commit aebf30b into civicrm:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants