Paypal class cleanup #16088
Merged
Paypal class cleanup #16088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove handling for returned error - this is never returned now - remove url parameter on invokeApi - this is never passed to it - throw an exception rather than use a fatal if curl not installed
|
(Standard links)
|
|
test this please |
|
This looks fine to me merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor cleanup
Before
We remove situations where CRM_Core_Error is returned from invokeAPI in #16072 -but handling remained
After
Handling cleaned up - other trivial cleanups per above
Technical Details
Comments