Allow Angular modules to provide dynamic HTML snippets

[colemanw]

Overview

Supports afforms dynamic templates by allowing angular partials to be passed as strings not just file paths.

See https://lab.civicrm.org/extensions/afform/merge_requests/16

Before

An Angular module must put HTML partials into specific files that live adjacent to the extension (e.g. files/civicrm/ext/myextension/ang/foo.html).

After

An Angular module may generate HTML partials dynamically - using a callback function, e.g.

function mymod_civicrm_angularModules(&$modules) {
  $modules['mymod'] = [
    // ...
    'partialsCallback' => 'mymod_get_partials',
  ];
}

function mymod_get_partials(string $moduleName, array $module) {
  return [
    '~/mymod/greeting.html' => '<p>Hello world!</p>',
  ];
}

Comments

I thought about a lot of clever ways to do this, settled on a one-liner. KISS.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

@civicrm-builder retest this please

[totten]

Yeah, I'd also spent a lot of time looking for a "elegant" way (in particular, making the different forms of local-files and dynamic-files use similar notations). It's tough row, so +1 on the KISS approach.

However, I've pushed an update to use a slightly different contract. As discussed in afform!16, the snippets => [string $filename => string $html] contract means that it would load the full HTML content of all *.aff.html files even in the case where they're not needed. (Which is more likely to be common since Afform is biased toward standalone base-pages.) The update uses a callback instead of an array of HTML content. I'll update the description with more details.

[totten]

The r-run seems good on top of afform!16. However, since I changed it a bit from the original submission, I'm marked "merge ready" in case there's more feedback.

[colemanw]

Well now that "HTML" has been properly capitalized in the title, it's definitely ready to merge ;)