Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap out fatal for statusBounce for disabled or unpermitted forms #16067

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Swap out fatal for statusBounce for disabled or unpermitted forms #16067

merged 1 commit into from
Dec 10, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Code cleanup as part of ongoing initiative

Before

Fatal error when user is not allows to access a page

After

Status bounce

Technical Details

I have deliberately left copy editing & translate out of scope & focussed on a specific narrow pattern

Comments

@civibot
Copy link

civibot bot commented Dec 10, 2019

(Standard links)

@civibot civibot bot added the master label Dec 10, 2019
@seamuslee001
Copy link
Contributor

Looks good to me merge on pass

@yashodha
Copy link
Contributor

test this please

@eileenmcnaughton
Swap out fatal for statusBounce for disabled or unpermittted forms
beb414c 
I have deliberately left copy editing & translate out of scope & focussed on a specific narrow pattern
@seamuslee001 seamuslee001 merged commit 3329ccb into civicrm:master Dec 10, 2019
@seamuslee001 seamuslee001 deleted the fatal branch December 10, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @yashodha