dev/core#1447 Fix upgrade error when duplicate option group names

[seamuslee001]

Overview

This fixes a hard fail that can happen in the upgrade process if the same name as the fixed name for an option group already exists in the database

https://lab.civicrm.org/dev/core/issues/1447

Before

Hard Fail in upgrade can happen

After

No hard fail and report generated of option groups that couldn't be fixed

ping @mlutfy

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mlutfy]

I did a test run (after manually creating an option group with a conflicting name)

> select * from civicrm_option_group where name like '%rating%';
+-----+-------------------------------+----------------+-------------+-------------+-----------+-----------+-----------+
| id  | name                          | title          | description | is_reserved | is_active | is_locked | data_type |
+-----+-------------------------------+----------------+-------------+-------------+-----------+-----------+-----------+
| 358 | numeric_rating                | Numeric Rating | NULL        |           1 |         1 |         0 | Integer   |
| 359 | numeric_rating_20171003141125 | Numeric rating | NULL        |           0 |         1 |         0 | String    |
| 377 | numeric rating                | numeric rating | test by bgm |           1 |         1 |         0 | Integer   |
+-----+-------------------------------+----------------+-------------+-------------+-----------+-----------+-----------+

and indeed got:

Upgrade outputs:
The Following option Groups have not been converted due to there being
already another option group with the same name in the database

        * numeric rating

and other than the warning, everything went well.

Should the PR be aginst the RC / 5.21?