dev/core#1436 Do not CC or BCC Contribution invoice

[magnolia61]

Overview

Contribution Invoices were send to CC and BCC email adress that were configured only for Event Confirmation purposes.

Opinions and discussion over at: https://lab.civicrm.org/dev/core/issues/1436

Before

When sending an invoice to a user it automatically also got send to the CC and BCC email that were configured for Event Confirmation purposes. While these email addresses are in use to let the event leaders know how many participants can be expected and info on their diet etcetera, it is an unexpected and undesered result when sensitive contribution details (payment arrangements etcetera) are automatically send by CC and BCC to these people.

After

Only the contribution contact gets the contribution invoice.

Technical Details

just removed CC and BCC from the function

Comments

I can understand some organizations would feel the need to have CC of BCC options for the contribution invoice mechanism. If so, that should be coded. But automatically (and non-configurable) send contribution invoices to people not configured to receive these should not happen.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@magnolia61 Can you clarify - is this for an event contribution?

[magnolia61]

@magnolia61 Can you clarify - is this for an event contribution?

Yes, I also opened up a gitlab issue to discuss this problem and best solution
https://lab.civicrm.org/dev/core/issues/1436

[jaapjansma]

Betty and I are reviewing PR's and we came across this PR.

• General standards
  • Explain (r-explain)
    • PASS : The goal/problem/solution have been adequately explained in the PR and in the issue.
  • User impact (r-user)
    • PASS: The change would be intuitive altough the e-mail invoice screen does not say (and did not) that the invoice is send to this person only.
  • Documentation (r-doc)
    • PASS: The user documentation should be updated. We have updated the docs see: Update invoicing.md civicrm-user-guide#429
  • Run it (r-run)
    • PASS: We have tested it with and without the patch. With this PR applied the CC and BCC
• Developer standards
  • Technical impact (r-tech)
    • PASS: The change preserves compatibility with existing callers/code/downstream.
  • Code quality (r-code)
    • PASS: The functionality, purpose, and style of the code seems clear+sensible.
  • Maintainability (r-maint)
    • PASS: The change is trivial enough that it does not require tests.
  • Test results (r-test)
    • PASS: The test results are all-clear.

@mattwire or @eileenmcnaughton can you merge this PR? And also the docs PR?

[homotechsual]

Docs PR is approved for merge-on-release. Please don't merge the docs PR - we'll do this when the change releases (or as close to release as possible!)

r-doc is PASS

[magnolia61]

Thanks guys!