dev/core1329 Reduce number of deceased contacts in the demo data from… #15967
Conversation
|
(Standard links)
|
sql/GenerateData.php
Outdated
| @@ -649,7 +649,7 @@ private function addIndividual() { | |||
| } | |||
|
|
|||
| // Deceased probability based on age | |||
| if ($age > 40) { | |||
| if ($age > 60) { | |||
There was a problem hiding this comment.
Thanks @seamuslee001
Can we try this, if male then 64 years and if female then 68 years.
Refs:
https://www.hcf.com.au/health-agenda/health-care/research-and-insights/life-expectancy-in-australia
https://www.qgso.qld.gov.au/statistics/theme/population/vital-statistics/life-expectancy#current-release-life-expectancy-birth-years-sex-qld-australia
|
An alternate approach would just be to set 2 people to deceased rather than a random spread. Related Gitlab, https://lab.civicrm.org/dev/core/issues/1329 Agileware Ref: CIVICRM-1377 |
seamuslee001
force-pushed
the
dev_core_1329
branch
from
2ed4562 to
770a885
Compare
… 31 to 12 Limit number of deceased contacts to 4 and add in age checks as per Justin
seamuslee001
force-pushed
the
dev_core_1329
branch
from
770a885 to
ca7a715
Compare
|
ok @jusfreeman have implemented those changes now |
There was a problem hiding this comment.
@seamuslee001 thanks, looks good to me. With this change we will have at most 4 deceased contacts in the demo data, that's a definite improvement!
|
Merging as per Justin's review |
… 31 to 12
Overview
This reduces the number of deceased persons in the sample data from currently on dmaster 31 to 12
ping @jusfreeman @eileenmcnaughton