dev/core#1374 Fix search formValue handling on contribu… #15896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I can confirm that this resolves the problem of "Next" link on a contribution search returning all contributions. |
seamuslee001
changed the title
|
Marking Merge on Pass as per @mfb 's testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion search
Overview
This is a backport of #15781 which aims to fix the issues in dev/core#1374 and the searching on sort name
Before
formValues get lost when editing a related entity and cannot use force=1&sort_name filtering
After
both work
ping @mfb @eileenmcnaughton @totten