Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move CRM_Event_Form_EventFees::buildQuickForm to Participant_Form class #15871

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Moves code to a more logical place

Before

Function is CRM_Event_Form_EventFees::buildQuickForm

After

Moved to
CRM_Event_Form_Participant::buildEventFeeForm

Technical Details

After digging I found the form was only ever called from one class so it makes sense for it to belong on that class (& later to be unpacked to not be a static function)

Comments

@civibot
Copy link

civibot bot commented Nov 17, 2019

(Standard links)

@civibot civibot bot added the master label Nov 17, 2019
…rm class

It turns out this function is only ever used from the ParticipantForm class so moving it back there simplifies
that for people looking at the code
@mattwire mattwire merged commit 1d44726 into civicrm:master Nov 18, 2019
@eileenmcnaughton eileenmcnaughton deleted the init_fatal branch November 18, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants