FinancialTrxnTest - Fix unit test to be 'legit' #15799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
valid
branch
2 times, most recently
from
e1a863e to
dc36775
Compare
| @@ -141,40 +148,29 @@ public function testCreateDeferredTrxn() { | |||
| 'receive_date' => '2016-01-20', | |||
| 'total_amount' => 622, | |||
| 'financial_type_id' => 4, | |||
| 'line_items' => [ | |||
There was a problem hiding this comment.
These are for $100 but cont total is 622 = invalid data
| $total = CRM_Core_DAO::getFieldValue('CRM_Contribute_DAO_Contribution', $params['contribution_id'], 'total_amount'); | ||
| $cmp = bccomp($total, $paid, 5); | ||
| // If paid amount is greater or equal to total amount | ||
| if ($cmp == 0 || $cmp == -1) { |
There was a problem hiding this comment.
never true - never hit
eileenmcnaughton
force-pushed
the
valid
branch
from
dc36775 to
5ea38b9
Compare
totten
changed the title
This unit test is one of a bunch that came up as not creating valid payments. The issue is in the test set up methodology (the 'partial_payment_to_pay' key doesn't work). On tidying up the test proved to be mostly cruft from an earlier iteration
eileenmcnaughton
force-pushed
the
valid
branch
from
5ea38b9 to
f150189
Compare
|
@seamuslee001 test-only PR |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleans up a flawed unit test - identified in #15706
Before
Test setup results in incorrect payments created
After
Setup correct. Unhit lines of test removed.
Technical Details
This unit test is one of a bunch that came up as not creating valid payments. The issue is
in the test set up methodology (the 'partial_payment_to_pay' key doesn't work).
On tidying up the test proved to be mostly cruft from an earlier iteration
Comments