Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename balanceTrxnParams to paymentTrxnParams [REF] #15539

Merged
merged 1 commit into from
Oct 20, 2019
Merged

Rename balanceTrxnParams to paymentTrxnParams [REF] #15539

merged 1 commit into from
Oct 20, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Backport of #15535 for cleaner regression patching

@eileenmcnaughton
Rename balanceTrxnParams to paymentTrxnParams [REF]
f55dedf 
This array needs some fixes but I wanted to rename the parameter first as balanceTrxnParams is misleading.

The parameters are for the financial_trxn entry corresponding to the payment
@civibot
Copy link

civibot bot commented Oct 18, 2019

(Standard links)

@civibot civibot bot added the 5.19 label Oct 18, 2019
@mattwire
Copy link
Contributor

See comments on #15535 - I don't think this is the right change to make

@eileenmcnaughton
Copy link
Contributor Author

test this please

2 similar comments
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor Author

test this please

@mattwire
Copy link
Contributor

@eileenmcnaughton Fine! you've sold this via #15535

@mattwire mattwire merged commit 13cbd98 into civicrm:5.19 Oct 20, 2019
@eileenmcnaughton eileenmcnaughton deleted the pay_back branch October 20, 2019 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @mattwire @seamuslee001