Regression fix on Paypal Std with memberships not being finalised correctly. #15538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
reviewed
Oct 18, 2019
| @@ -336,7 +336,8 @@ public function main() { | |||
|
|
|||
| Civi::log()->debug('PayPalIPN: Received (ContactID: ' . $ids['contact'] . '; trxn_id: ' . $input['trxn_id'] . ').'); | |||
|
|
|||
| if ($this->retrieve('membershipID', 'Integer', FALSE)) { | |||
| // Debugging related to possible missing membership linkage | |||
| if ($contributionRecurID && $this->retrieve('membershipID', 'Integer', FALSE)) { | |||
There was a problem hiding this comment.
Doesn't this stop the membership processing from running if we don't have a recurring contribution? Where I found this Paypal was passing in a contribution ID + membership ID but it was not an auto-renew so there was no recurring. But the IPN still needed processing to "complete" the contribution and activate the membership.
There was a problem hiding this comment.
@mattwire I don't think so - this block was added to attempt to add in membership id if the underlying data had an issue to get back to behaviour that existed prior to one of the membership cleanups we collaborated on totten@fefee63#diff-508afec319247dd2f89dea484e473281R339 - skipping the block should be OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a regression per comment by @mattwire here Per #15053 (comment)
Before
Paypal std IPNs not updating memberships correctly
After
Normal behaviour
Technical Details
Just adds a precautionary if
Comments