Check requirements before upgrading extensions via the UI

[mattwire]

Overview

If an extension introduces a requirement on another extension but is ALREADY installed it will download and (attempt) to install the extension without checking those dependencies. This can result in CiviCRM crashing if there is a hard dependence.

This happens quite often for example when upgrading Stripe from 5.4.1 to 6.x which introduces the mjwshared extension as a requirement.

Before

CiviCRM can stop working if an extension is "upgraded" via the UI and it's (new) requirements are not met.

After

CiviCRM allows you to click "upgrade" but then bounces back with an error message if any dependencies are not already installed.

Technical Details

We modify a couple of checkrequirements functions to allow us to pass through the info retrieved via the http feed (ie. the new extension we want to install) instead of using the local (old) versions.

Comments

It is always nice to extend these things further but any attempt to automatically download / install would require far more work - contributions welcome but let's get this fix in first.

@totten @MikeyMJCO @aydun

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass prevents possibility of hard fails
  • (r-doc) Pass
  • (r-run) Pass

• I first ran a scenairo where i installed an old version of Mosaico extension which relied on both Shoreditch and Flexmailer. I then did the UI upgrade to the latest version which only relies on Flexmailer and confirmed that went through as expected
  I then downloaded an old version of the Stripe Extension and installed it, I then tried running hte upgrader and it failed due to an unmet dependancy. I then downloaded but not installed the dependancy and it still failed. After installing the depandancy then it succeeded.

I would say a future version should if all extensions are downloaded but not installed that the upgrade processes enables the dependancies

• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass
    @mattwire i would support this for 5.19 but will wait for others feedback

[mattwire]

I would say a future version should if all extensions are downloaded but not installed that the upgrade processes enables the dependancies

@seamuslee001 Yes it would be nice. It's just the way the extension downloader / upgrader code works at the moment it would be a lot more work and a much riskier change. So I just went for the simple user message

[seamuslee001]

Test failure unrelated merging