Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1302 fix regression on exported when merging addresses with specified fields #15443

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 8, 2019

Overview

Fixes a regression whereby merging contacts with same address fails if fields are specified

Before

Do a contact search.
Select some results.
Choose Export from the Actions dropdown.
Choose Selected Fields.
Choose the option "Merge All Contacts with the Same Address".
Pick your selected fields.
Export.

= DB error

After

Above works

Technical Details

Comments

Code still contains misery

@civibot
Copy link

civibot bot commented Oct 8, 2019

(Standard links)

@civibot civibot bot added the master label Oct 8, 2019
@eileenmcnaughton eileenmcnaughton changed the title dev/core#1302 fix regression on exported when merging addresses with … dev/core#1302 fix regression on exported when merging addresses with specified fields Oct 8, 2019
@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.19 October 8, 2019 09:23
@civibot civibot bot added 5.19 and removed master labels Oct 8, 2019
@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

  • General standards
    • (r-explain)Pass
    • (r-user) Pass
    • (r-doc) Pass
    • (r-run) Pass replicated the DB error and confirmed that this fixes the issue and confirmed that the resulting csv looks correct
  • Developer standards

@seamuslee001 seamuslee001 merged commit b4c078b into civicrm:5.19 Oct 8, 2019
@seamuslee001 seamuslee001 deleted the ex_merge branch October 8, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants