dev/core#1295 Add is_active field to civicrm_status_preference #15409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton Jenkins is displeased https://test.civicrm.org/job/CiviCRM-Core-PR/29164/checkstyleResult/new/ |
seamuslee001
reviewed
Oct 6, 2019
| @@ -25,14 +25,44 @@ | |||
| +--------------------------------------------------------------------+ | |||
| */ | |||
|
|
|||
|
|
|||
| use Civi\Api4\StatusPreference; | |||
There was a problem hiding this comment.
@eileenmcnaughton why is this needed?
seamuslee001
reviewed
Oct 6, 2019
CRM/Utils/Check/Component.php
Outdated
| if (empty($this->checksConfig)) { | ||
| $this->checksConfig = Civi::cache('checks')->get('checksConfig', []); | ||
| if (empty($this->checksConfig)) { | ||
| $this->checksConfig = StatusPreference::get()->execute()->indexBy('name'); |
There was a problem hiding this comment.
@eileenmcnaughton wouldn't you route through civicrm_api4 or similar or something?
eileenmcnaughton
force-pushed
the
status
branch
2 times, most recently
from
6d240e2 to
ac03bac
Compare
seamuslee001
reviewed
Oct 7, 2019
CRM/Utils/Check/Component.php
Outdated
| */ | ||
| public function checkAll() { | ||
| $messages = []; | ||
| foreach (get_class_methods($this) as $method) { | ||
| if ($method !== 'checkAll' && strpos($method, 'check') === 0) { | ||
| $r = $this->isDisabled($method); |
There was a problem hiding this comment.
@eileenmcnaughton what is this used for at all?
There was a problem hiding this comment.
@seamuslee001 thanks - fixed
Note this is done BEFORE doing checks in case it is for performance reasons
eileenmcnaughton
force-pushed
the
status
branch
from
ac03bac to
b4628ea
Compare
seamuslee001
added
the
merge ready
|
I've added merge ready as i think this is right but we may want to have a discussion about whether we want to be standardising on the OOP style API4 coding or use the traditional |
seamuslee001
added
merge on pass
and removed
merge ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add is_active field to civicrm_status_pref per discussions in NYC this is to be api-accessible but not UI exposed.
Importantly the is_active field is checked BEFORE attempting the check rather than after
Before
No way to stop a check from running at all
After
is_active field can be set to zero to disable
Technical Details
For devs to disable a status check they would need to add or edit a row in civicrm_status_check for that check - e.g
Comments