Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF Explicitly specify params so we can find problems with comparing translated labels #15397

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Oct 5, 2019

Overview

This makes no actual change - it explicitly specifies the default parameters so we can identify where we are comparing labels instead of names.

Before

More unclear

After

Less unclear

Technical Details

When loading on a form we have to use label which may be translated. When comparing we need to use field name which will always be the same

Comments

@civibot
Copy link

civibot bot commented Oct 5, 2019

(Standard links)

@civibot civibot bot added the master label Oct 5, 2019
@mattwire
Copy link
Contributor Author

mattwire commented Oct 5, 2019

@seamuslee001
Copy link
Contributor

This makes sense to me and at least will assist us in seeing where there maybe problems in our code base. @eileenmcnaughton make sense to you?

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 yeah sure - I guess it at least surfaces what is happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants