Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

financial#71 - allow emailing partially paid invoices #15388

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

MegaphoneJon
Copy link
Contributor

Overview

The "Email Invoice" functionality is hard-coded to not send partially paid invoices, even though the default invoice template supports them correctly.

Before

Can't email a partially paid invoice. You get the error Please select only contributions with Completed, Pending, Refunded status..

After

Partially paid invoices are emailed successfully.

Technical Details

If the PR introduces noteworthy technical changes, please describe them here. Provide code snippets if necessary

Comments

Steps to replicate:

  • You need to enable tax/invocing under CiviContribute Component Settings
  • Create a pending contribution on the back end.
  • Record a partial payment on the contribution.
  • View the contribution and press "Email invoice".

@civibot
Copy link

civibot bot commented Oct 4, 2019

(Standard links)

@MegaphoneJon
Copy link
Contributor Author

Eileen overruled me last time, but I genuinely think this qualifies for the easy-review tag.

@eileenmcnaughton
Copy link
Contributor

Lol - yes seems fine to me - test fail is unrelated

@eileenmcnaughton eileenmcnaughton merged commit 7a464f3 into civicrm:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants