Add test for uF group one bug #15381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Note that you'll want to rebase - I did some additional fixes on the original PR. |
eileenmcnaughton
force-pushed
the
w_test
branch
from
ecf2814 to
ed11631
Compare
eileenmcnaughton
force-pushed
the
w_test
branch
from
ed11631 to
a04af76
Compare
|
I've updated this against master & added checks that the titles for 2 & 3 are correct |
seamuslee001
reviewed
Oct 6, 2019
Comment on lines
+97
to
+103
| $profileID = $this->ids['UFGroup']['dummy']; | ||
| CRM_Core_DAO::executeQuery('UPDATE civicrm_uf_group SET id = 1 WHERE id = 900'); | ||
| CRM_Core_DAO::executeQuery("UPDATE civicrm_uf_join SET uf_group_id = 1 WHERE uf_group_id = $profileID"); | ||
| CRM_Core_DAO::executeQuery("UPDATE civicrm_uf_field SET uf_group_id = 1 WHERE uf_group_id = $profileID"); |
There was a problem hiding this comment.
@eileenmcnaughton maybe put a if (!empty($this->ids['UFGroup'])) around these lines?
eileenmcnaughton
force-pushed
the
w_test
branch
from
a04af76 to
f736929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test for #15380