Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1279 - crmMailingRadioDateSpec.js always has a failure if west of GMT #15366

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

demeritcowboy
Copy link
Contributor

Overview

There's a line where it sets a date, but the way it does it it inadvertently converts to local time, so if west of GMT then when it compares using toDateString() later it is always the day before.

@civibot
Copy link

civibot bot commented Oct 1, 2019

(Standard links)

@colemanw
Copy link
Member

colemanw commented Oct 1, 2019

Thanks @demeritcowboy looks good. Adding MOP because this is test-only.

@seamuslee001 seamuslee001 merged commit b5bcd2b into civicrm:master Oct 1, 2019
@demeritcowboy
Copy link
Contributor Author

Thanks!
Misc thought that is probably not worth the effort: If the jenkins script could tell that the only file changes are karma tests, it could end the test run early (whether it's pass or fail) since the karma tests seem to run even before the database gets loaded and everything else.

@demeritcowboy demeritcowboy deleted the radio-date-gmt branch October 1, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants