Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that price_field_value rows aren't duplicated when editing pri… #15350

Merged
merged 1 commit into from
Sep 26, 2019

Conversation

seamuslee001
Copy link
Contributor

…ce field of type text

Overview

Fixes an issue where editing a price field of type text causes a duplicate price_field_value row to be created for it

Before

Duplicate row for price_field_value created

After

No duplicate rows

ping @MegaphoneJon @mattwire

@civibot
Copy link

civibot bot commented Sep 26, 2019

(Standard links)

@civibot civibot bot added the 5.18 label Sep 26, 2019
@MegaphoneJon
Copy link
Contributor

I just did an r-run on this and confirmed that it fixes the bug.

@colemanw colemanw merged commit 063dac3 into civicrm:5.18 Sep 26, 2019
@seamuslee001 seamuslee001 deleted the lab_core_1276 branch September 26, 2019 20:36
@agh1
Copy link
Contributor

agh1 commented Oct 1, 2019

Just closing the loop--this is documented in dev/core#1276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants