Api3TestTrait - Only run api4 tests if api4 is present #15331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is meant to temporarily hush issues in
api_v3_AllTestswhen running a mid-alpha codebase.Before
api_v3_AllTests, the tests always run on v3 and v4.After
api_v3_AllTests, the active tests depend on what code is present. It runs v4 mode if v4 is present.Technical Details
This is meant to help bridge the interim while updating test systems and working on #15309.
The test is framed in a way that should work in a minimal level of bootstrap (e.g. after classloader and
civicrm.settings.php- but before API is brought online).