Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailing API - Expose option list for header_id and footer_id #15325

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

totten
Copy link
Member

@totten totten commented Sep 18, 2019

Overview

In APIv3, the actions getoptions and getfields are able to list options for most fields. This expands that function to more fields.

Before

The API does not return the option list for Mailing.header_id or Mailing.footer_id.

$ cv api Mailing.getoptions field=header_id
{
    "is_error": 1,
    "error_message": "The field 'header_id' has no associated option list."
}

After

The API does return the option list for Mailing.header_id or Mailing.footer_id.

$ cv api Mailing.getoptions field=header_id
{
    "is_error": 0,
    "version": 3,
    "count": 1,
    "id": 1,
    "values": {
        "1": "Mailing Header"
    }
}

@civibot
Copy link

civibot bot commented Sep 18, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

Change looks good to me merging

@seamuslee001 seamuslee001 merged commit 0c69cc0 into civicrm:master Sep 18, 2019
@totten totten deleted the master-mailing-options branch September 19, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants