Extend Export test to cover altering sqlColumns and headerRows via ho… #15312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| * | ||
| */ | ||
| public function confirmHookWasCalled(&$exportTempTable, &$headerRows, &$sqlColumns, $exportMode, $componentTable, $ids) { | ||
| $sqlColumns['display'] = 'dipslay varchar(255)'; |
There was a problem hiding this comment.
@seamuslee001 Is the dipslay typo on purpose - shouldn't that make something fail? Ignore me if I'm just misunderstanding this test.
There was a problem hiding this comment.
hmm i don't think it was meant to fail as i think the header rows does the trick and i have essentially compensated in L145 but i will fix this up anyway
…ok_civicrm_export
seamuslee001
force-pushed
the
export_hook_test
branch
from
9e74899 to
4224fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ok_civicrm_export
Overview
Extend export unit test to cover altering sqlColumns and headerRows via the hook_civicrm_export
Before
No test based on the hook
After
Test based on the hook
ping @eileenmcnaughton @MegaphoneJon