CRM-21777 - Set readonly for the smtp fields initialised in civicrm_s…

[yashodha]

…ettings.php

Overview

Load input for smtp fields as non-editable which have been initialized in civicrm.settings.php.

Before

SMTP Server OR SMTP Server settings initialized in civi settings file are still shown as editable in civicrm/setting/smtp?reset=1. This has already been fixed for other places setting urls etc.

After

SMTP fields initialized in civicrm.settings.php are loaded as readonly.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Hi @yashodha this works well there's just one r-run issue below.

• General standards
  • [r-explain] PASS It took me a bit to figure out how to set the settings in civicrm.settings.php, since it isn't one of the sample/documented ones. And this PR only applies when you have the outbound choice set to SMTP. But otherwise it's obvious what it's about. Example:
    • $civicrm_setting['Mailing Preferences']['mailing_backend']['smtpPort'] = '587';
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] Issue
    • Warning about invalid parameter to foreach when you have a "normal" install that doesn't have any of these overrides. Need to change line 58 since getMandatory returns NULL. I would change it to this:
      $settings = Civi::settings()->getMandatory('mailing_backend') ?? [];
• Developer standards
  • [r-tech] PASS
  • [r-code] PASS
  • [r-maint] Undecided
  • [r-test] PASS

[yashodha]

@demeritcowboy Thanks for catching that! I have made the desired changes.

[demeritcowboy]

Groovy. I had already tested the suggested change locally earlier so looks good to me.

[yashodha]

@eileenmcnaughton Do you want to merge this?

[eileenmcnaughton]

Ok merging per @demeritcowboy review

[yashodha]

@eileenmcnaughton thanks!