REF Make the formatParamsForPaymentProcessor function more generic so it can be used more

[mattwire]

Overview

Currently this useful function that helps standardise parameters passed to the payment processor is limited in where it can be used because it hardcodes the params array as $this->_params.
Because it also returns a specific "fields" array which is used for the profileContact function I've created a new function with a different signature so we don't break backward compatibilty.

Before

Not possible to use formatParamsForPaymentProcessor in many places

After

Possible to use formatParamsForPaymentProcessor in many places

Technical Details

Comments

There are some other bits we could probably pull into this function such as the parsing of credit card expiry date.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I worked through this locally & was able to reach the same conclusion. Happy for this to be merged with one minor comment fix

[mattwire]

Thanks for the review @eileenmcnaughton I've fixed the comment

[eileenmcnaughton]

unrelated fail