Trim form values when adding LIKE operator #15275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more consistent with previous behaviour - ie '[email protected]' AND '[email protected] ' should work.
|
(Standard links)
|
|
Yeh makes sense IMO adding MOP as i'm sure we have tests |
Merged
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jan 7, 2020
civicrm#15275 Bug: T232532 Change-Id: Id98f0956769a87d64345e2bac18777e7113ad1fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix a 5.17 regression whereby the email string is no longer being trimmed when searching
Before
'[email protected]' works
After
'[email protected] ' doesn't work
Technical Details
The form layer seems like the right place to trim & it makes sense to be generic when adding 'LIKE'
Comments