(REF) Remove unused functions, setTemplateMenuValues() and getNavigation() #15274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this is a `private` function, so any hypothetical callers must be
in the same class. There don't appear to be any.
Could there be some dynamic method calls? Well, you'd expect there to be
some tell-tale such as references to `call_*()` or to a string which builds
up that method name from smaller strings ("set" or "MenuValues" or similar).
Nothing comes up.
I stumbled across this function while grepping to cleanup up `userFrameworkURLVar` (dev/drupal#52). Notice the first line of the function throws a fatal error. That line has been there since at least CiviCRM v4.3. https://github.com/civicrm/civicrm-core/blob/4.3/CRM/Core/Menu.php#L310 Unsurprisingly, if you grep for `getNavigation`, there are no calls to this function.
|
(Standard links)
|
|
Makes sense to me Merge on pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unused functions.
These popped on my radar while grepping for consumers of
userFrameworkURLVar(which needs to be refactored per dev/drupal#52). This just removes some noise from consideration.Before
There are at least two unnecessary functions.
After
There are two less unnecessary functions.
Comments
More detailed comments are in the git commit notes.