dev/financial#68 Ensure that check number is correctly passed through… #15272
Conversation
… when processing a contribution or membership batch
|
(Standard links)
|
…m as contribution_check_number is correctly saved into the financial Transaction
|
Approach makes sense - will let @monishdeb chime in |
|
@eileenmcnaughton @seamuslee001 I am happy with the patch too. Earlier I was thinking, instead of tackling in the form or BAO level we should remove the deprecated field names from the source and so I changed the field name, and let the BAO fn process it accordingly. On the other hand, if we create a profile with contribution field - check number it again renders the field name as 'contribution_check_number' and thus it will again cause the same issue after form submission until and unless we change the field name from the source. OR let BAO/API to support the old fieldname too. |
|
The api should support unique names & real field names at the wrapper level already - but this is bypassing the api |
|
Jenkins re test this please |
|
@monishdeb @eileenmcnaughton i just added a commit which alters a current contribution api test so that it submits using the unique field name contribution_check_number and then checks that check_number is still correctly stored in the financial trxn records as well as in civicrm_contribution |
| @@ -233,7 +233,7 @@ public function testGetTestContribution() { | |||
| */ | |||
| public function testGetContributionReturnFunctionality() { | |||
| $params = $this->_params; | |||
| $params['check_number'] = 'bouncer'; | |||
| $params['contribution_check_number'] = 'bouncer'; | |||
There was a problem hiding this comment.
ideally both should work - maybe test both?
There was a problem hiding this comment.
Done @eileenmcnaughton
…ied in unique field it is still correctly stored Add in a unit test to test setting check_number with original field
seamuslee001
force-pushed
the
dev_financial_68
branch
from
78feaba to
7d96cec
Compare
|
Ok - @monishdeb agreed earlier so MOP |
… when processing a contribution or membership batch
Overview
This is an alternate to #15264 as it alters the post processing on the batch rather than altering field names as the field_name should be contribution_check_number now
Before
Check number is only recorded against the contribution not the payment as well when submitting a contribution or membership batch
After
Check number is recorded against the contribution and the payment
ping @monishdeb @eileenmcnaughton