[Ref] [Import] more code cleanup #15219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
jsSet is always TRUE when if ([] != ts('- do not import -')) {
so we don't need it
eileenmcnaughton
force-pushed
the
import_next
branch
from
7025cec to
b7b5e2d
Compare
eileenmcnaughton
commented
Sep 5, 2019
CRM/Contact/Import/Form/MapField.php
Outdated
| @@ -70,7 +70,7 @@ class CRM_Contact_Import_Form_MapField extends CRM_Import_Form_MapField { | |||
| public function defaultFromColumnName($columnName, $patterns) { | |||
|
|
|||
| if (!preg_match('/^[a-z0-9 ]$/i', $columnName)) { | |||
| if ($columnKey = array_search($columnName, $this->_mapperFields)) { | |||
| if ($columnKey = array_search($columnName, $this->getFieldTitles())) { | |||
There was a problem hiding this comment.
- makes it testable
eileenmcnaughton
force-pushed
the
import_next
branch
from
b7b5e2d to
d2d3b4e
Compare
|
@seamuslee001 @colemanw this is pretty trivial + tested |
|
makes sense and we have a good solid set of unit tests for this area merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes code complexity that is not longer required
Before
Less readable
After
More readable
Technical Details
Builds off #15218
Comments