Someimes ya just gotta say enough already

[eileenmcnaughton]

Overview

Spot the problem

          if ($websiteTypeId) {
            $defaults["mapper[$i]"] = [$relation, $contactDetails, $websiteTypeId];
            if (!$websiteTypeId) {
              $js .= "{$formName}['mapper[$i][2]'].style.display = 'none';\n";
            }
          }

Before

Oh so silly

After

less silly

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

If the code never worked in the first place, we probably don't need it!