core#1225 fix Event Info and Contribution Page Settings templates #15168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@MegaphoneJon I added a sig-markup label to allow Compucorp to identify things that could affect shoreditch |
|
How long should we wait before merge? Themes can do QA during the RC period? |
|
@mlutfy i don't think we should wait i'm going to merge this |
|
@mlutfy @seamuslee001 I don't actually think we should wait when we give that label - I didn't merge it earlier because I hadn't reviewed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This makes some changes to templates that should not be visible to end users, but makes the underlying HTML less ugly.
Before
Elements are positioned by use of this line:
After
We use sane rendering techniques to position our elements, and use the same positioning techniques on identical elements.
Technical Details
There's almost no technical detail to mention.
Comments
This started out as my adding a class to a table cell that had none on the event info template, but when I saw what the contribution page template looked like I expanded my scope to remove something rather hideous.