Replace some calls to CRM_Core_Error::fatal with exceptions

[eileenmcnaughton]

Overview

Continues ongoing changes to replace CRM_Core_Error::fatal with

• status bounce in forms where appropriate otherwise
• throwing exceptions

Before

Fatal used

After

Exception used

Technical Details

@seamuslee001 @mattwire @colemanw we've replaced a lot of these with no fallout - maybe we should pick up the pace on them? We finally got to the end of $dao->free()

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@seamuslee001 ok with this?

[seamuslee001]

@eileenmcnaughton should we be tsing these Exceptions?

[eileenmcnaughton]

@seamuslee001 it seems to 'depend' - in this case I left it unchanged

[eileenmcnaughton]

I would note these are 'should never be hit' exceptions

[seamuslee001]

I've umed and arded over whether we need to ts i don't think so in this case so merging