Open up permissions on Dedupe.getduplicates #15152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Currently the action Dedupe.getduplicates is defaulting to 'administer CiviCRM'. The function manages permissions internally (ie. you can't retrieve contacts you don't have permission to see) so the function itself can have fairly open permissions - hence I went for 'access CiviCRM' rather than 'merge duplicate contacts' - it might even be argued this should be open & rely solely on contact ACLs but I have not gone that far This function is part of moving towards api based rather than form based logic. It is not in use in core yet outside tests.
eileenmcnaughton
force-pushed
the
dedupe
branch
from
4061a79 to
cc47769
Compare
|
Test fails unrelated merging |
eileenmcnaughton
added a commit
to eileenmcnaughton/deduper
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Less restrictive permissions on Dedupe.getduplicates api - currently only used from unit tests.
Currently the action Dedupe.getduplicates is defaulting to 'administer CiviCRM'.
The function manages permissions internally (ie. you can't retrieve contacts you don't have permission to see) so the function itself can have fairly open permissions - hence I went for 'access CiviCRM' rather than 'merge duplicate contacts' - it might even be argued this should be open & rely solely on contact ACLs but I have not gone that far
Before
Dedupe.getduplicates requires 'Administer CiviCRM'
After
Dedupe.getduplicates requires 'AccessCiviCRM'
Technical Details
This function is part of moving towards api based rather than form based logic. It is not in use in core yet outside tests.
Comments