Ensure that civicrm_dashboard has a foreign key to civicrm_domain #15119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
fix_dashboard_domain_fk
branch
2 times, most recently
from
9e9b81d to
837a0ce
Compare
| @@ -35,6 +35,7 @@ | |||
| <table>civicrm_domain</table> | |||
| <key>id</key> | |||
| <add>3.1</add> | |||
| <onDelete>CASCADE</onDelete> | |||
There was a problem hiding this comment.
well the column def is a NOT NULL column so its the only one that seemed to make sense to me
|
test fail relates |
Fix upgrade on multilingual installs
seamuslee001
force-pushed
the
fix_dashboard_domain_fk
branch
from
837a0ce to
1494e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After checking out production db i noticed we only had an index no actual foreign key between civicrm_dashboard and civicrm_domain. This runs an upgrade to make sure there is the FK
Before
Maybe index maybe FK
After
FK instantiated
ping @christianwach @eileenmcnaughton