[REF] minor code refactor on import - Pass ProcessorObject into loadSavedMapping & use it to load the formName #15068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -396,12 +400,16 @@ public function buildQuickForm() { | |||
| $formName = 'document.forms.' . $this->_name; | |||
| //used to warn for mismatch column count or mismatch mapping | |||
| CRM_Core_Session::singleton()->setStatus(NULL); | |||
| $processor = new CRM_Import_ImportProcessor(); | |||
| $processor->setMappingID($savedMappingID); | |||
There was a problem hiding this comment.
Not actually using mappingId & metadata yet but it seemed like the 'right sized bite' to include these sets in this pr
eileenmcnaughton
force-pushed
the
mapping_test
branch
2 times, most recently
from
f19a2d1 to
0405fa6
Compare
|
@seamuslee001 this is passing now - can you merge it - I'm keen to get the full processor class in (this brings in more but not all) so I can start switching to it with tests. |
eileenmcnaughton
force-pushed
the
mapping_test
branch
from
0405fa6 to
53359dc
Compare
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Aug 19, 2019
This adds the full ImportProcessor class from the WIP pr civicrm#15034 - minus the functions that replace loadSavedMapping) along with tests. It does NOT start to use the new class as yet. Note that civicrm#15068 will need rebasing if this is merged first & vice versa The goal is to bring it into use along with extending tests but this is 'safe' in that no funcitonal code is changed
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Aug 19, 2019
This adds the full ImportProcessor class from the WIP pr civicrm#15034 - minus the functions that replace loadSavedMapping) along with tests. It does NOT start to use the new class as yet. Note that civicrm#15068 will need rebasing if this is merged first & vice versa The goal is to bring it into use along with extending tests but this is 'safe' in that no funcitonal code is changed
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Aug 19, 2019
This adds the full ImportProcessor class from the WIP pr civicrm#15034 - minus the functions that replace loadSavedMapping) along with tests. It does NOT start to use the new class as yet. Note that civicrm#15068 will need rebasing if this is merged first & vice versa The goal is to bring it into use along with extending tests but this is 'safe' in that no funcitonal code is changed
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Aug 19, 2019
This adds the full ImportProcessor class from the WIP pr civicrm#15034 - minus the functions that replace loadSavedMapping) along with tests. It does NOT start to use the new class as yet. Note that civicrm#15068 will need rebasing if this is merged first & vice versa The goal is to bring it into use along with extending tests but this is 'safe' in that no funcitonal code is changed
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Aug 19, 2019
This adds the full ImportProcessor class from the WIP pr civicrm#15034 - minus the functions that replace loadSavedMapping) along with tests. It does NOT start to use the new class as yet. Note that civicrm#15068 will need rebasing if this is merged first & vice versa The goal is to bring it into use along with extending tests but this is 'safe' in that no funcitonal code is changed
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Aug 19, 2019
This adds the full ImportProcessor class from the WIP pr civicrm#15034 - minus the functions that replace loadSavedMapping) along with tests. It does NOT start to use the new class as yet. Note that civicrm#15068 will need rebasing if this is merged first & vice versa The goal is to bring it into use along with extending tests but this is 'safe' in that no funcitonal code is changed
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Aug 19, 2019
This adds the full ImportProcessor class from the WIP pr civicrm#15034 - minus the functions that replace loadSavedMapping) along with tests. It does NOT start to use the new class as yet. Note that civicrm#15068 will need rebasing if this is merged first & vice versa The goal is to bring it into use along with extending tests but this is 'safe' in that no funcitonal code is changed
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Aug 19, 2019
This adds the full ImportProcessor class from the WIP pr civicrm#15034 - minus the functions that replace loadSavedMapping) along with tests. It does NOT start to use the new class as yet. Note that civicrm#15068 will need rebasing if this is merged first & vice versa The goal is to bring it into use along with extending tests but this is 'safe' in that no funcitonal code is changed
After a few more steps we can eliminate most of this function & use the processor but this is jusut a very small change....
eileenmcnaughton
force-pushed
the
mapping_test
branch
from
53359dc to
a2ca56e
Compare
|
Merging based on code review & passing tests. |
|
thanks @colemanw |
magnolia61
pushed a commit
to magnolia61/civicrm-core
that referenced
this pull request
Oct 13, 2019
This adds the full ImportProcessor class from the WIP pr civicrm#15034 - minus the functions that replace loadSavedMapping) along with tests. It does NOT start to use the new class as yet. Note that civicrm#15068 will need rebasing if this is merged first & vice versa The goal is to bring it into use along with extending tests but this is 'safe' in that no funcitonal code is changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Small change towards a larger cleanup
Before
Long list of params
After
Still a long list of params but $formName replaced by processor which can later replace all the rest.
Technical Details
After a few more steps we can eliminate most of this function & use the processor - baby step towards #15034
Comments
@seamuslee001