dev/core#1186 - ignore exception if no description field

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/issues/1186

Before

Datatables error because of uncaught exception

After

Golden silence.

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@demeritcowboy I think it would be helpful if we were able to generate a unit test here

[demeritcowboy]

@seamuslee001 I agree but I need to push back a little. Just no promises.

[eileenmcnaughton]

@seamuslee001 I agree but I also think we should be more lenient when people are fixing regressions - so patch desirable but not required here IMHO

[eileenmcnaughton]

@mattwire are you able to test?

[seamuslee001]

added a unit test here #15058

[eileenmcnaughton]

this looks safe to me & has a test now - merging

[demeritcowboy]

Thanks!

[mattwire]

Thanks @demeritcowboy @eileenmcnaughton

[MegaphoneJon]

With PR #14658 applied (currently unreleased) this bug popped up on me today when generating PDF letters. So I applied this patch and can also confirm it fixes the issue.