Event confirm - (very) minor cleanup + test #15010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've just started delving into this & have 1) added a test 2) removed an assign that is ALSO done in the sendMail function - ie participantID - this is tested 3) removed a pass-by-reference that I checked was not required
|
(Standard links)
|
| @@ -928,7 +928,6 @@ public function postProcess() { | |||
|
|
|||
| //send mail to primary as well as additional participants. | |||
| $this->assign('contactID', $contactId); | |||
| $this->assign('participantID', $participantID); | |||
There was a problem hiding this comment.
@eileenmcnaughton is the participantID field exposed on any confirm step or thank you step form or is this assign just about the smarty email template?
There was a problem hiding this comment.
yeah after this line the only remaining thing that happens is calling sendEmail + it iterates through multiple participantIDs so it would be the 'last one'
|
Changes make sense here and are well backed up by a unit test adding MOP |
|
Failures are due to test changes - ie I set is_email_confirm = 1 & need to adjust other tests to 'cope' |
|
ug - they pass in isolation.... a static is in play :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Preliminary cleanup & test as I delve into this code
Before
Less tested
After
More tested
Technical Details
Comments