dev/core#561 Remove last free jcalendar #14150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
test this please |
|
|
||
| //campaign end date. | ||
| $this->addDate('end_date', ts('To'), FALSE, ['formatType' => 'searchDate']); | ||
| $this->add('datepicker', 'start_date', ts('From'), [], FALSE, ['time' => FALSE]); |
There was a problem hiding this comment.
@eileenmcnaughton this works but just wondering if we should put something like Start Date From as the label and a la the end_date as at the moment its not obvious what field your filtering
There was a problem hiding this comment.
@seamuslee001 OK - I checked the xm & it uses Campaign Start Date so using that - I can't be bothered switching to addField for this last obscure form but for the search range ones on the search forms we should do it properly (like we did for activity & grant)
This is the last jcalendar outside of buildDateRange instances. It turns out to be 'just a form' and pretty straight forward
eileenmcnaughton
force-pushed
the
last_free_jcal
branch
from
80b6995 to
c116404
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is the last jcalendar outside of buildDateRange instances.
It turns out to be 'just a form' and pretty straight forward
Before
jcalendar
After
datepicker - no user change
Technical Details
Comments