Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed double protocol being added in link by CKEditor. #14128

Merged
merged 1 commit into from
Apr 27, 2019

Conversation

agilewarealok
Copy link
Contributor

Overview

Adding action tokens using the CKEditor link interface can easily cause double protocols
Before

Steps to reproduce:

  1. Create a mailing.
  2. Add a link using the CKEditor link button
  3. The "protocol" should be http:// (if it isn't set to this already, change it, but this has come up because http:// was the default)
  4. Set the URL to {action.forward}
  5. Add some text, e.g. "Forward"
  6. Preview the mailing, and inspect the link; note that it has an href starting with http://https:// or http://http://

Before

Links are added with double protocols, http://https:// or http://http://

After

Links have only a single protocol.

Comments

Agileware Ref: CIVICRM-1143

@civibot
Copy link

civibot bot commented Apr 25, 2019

(Standard links)

@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

  • General standards
    • (r-explain) Pass
    • (r-user) Pass
    • (r-doc) Pass
    • (r-run) Pass i reviewed the code, wrote a unit test to lock it in and confirmed it fixes the bug after exposing the bug in the unit test
  • Developer standards

@seamuslee001 seamuslee001 merged commit 850d8c7 into civicrm:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants