Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#880: Fix typo in DROP table query. #14123

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Conversation

mfb
Copy link
Contributor

@mfb mfb commented Apr 24, 2019

Overview

The DROP table query in the utf8mb4 is missing its $conn argument. Hat tip johnk: https://lab.civicrm.org/dev/core/issues/880#note_16365

Before

utf8mb4 test fails if run again because table already exists.

After

Drop table if it exists; properly drop table after running test.

@civibot
Copy link

civibot bot commented Apr 24, 2019

(Standard links)

@civibot civibot bot added the master label Apr 24, 2019
@seamuslee001
Copy link
Contributor

PR looks right Merging

@seamuslee001 seamuslee001 merged commit de5a078 into civicrm:master Apr 24, 2019
@kcristiano
Copy link
Member

@seamuslee001 Could this be considered for 5.13 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants