Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Pledge Calander Date and Start Date for pledges to use datepic… #14099

Conversation

seamuslee001
Copy link
Contributor

…ker rather than jcalendar

Overview

This converts the pledge_calendar_date and start_date fields for pledges in association of Contribution Pages to using datepicker rather than jcalendar

Before

deprecated jcalendar used

After

using modern datepicker

ping @eileenmcnaughton @monishdeb @mattwire

@civibot
Copy link

civibot bot commented Apr 21, 2019

(Standard links)

@civibot civibot bot added the master label Apr 21, 2019
* Supports altering future start dates
* @return bool
*/
public function supportsFutureRecurStartDate() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just makes it so that when your using the dummy processor you can expose the pledge date field on contribution front page

@seamuslee001 seamuslee001 force-pushed the pledge_dates_contribution_form_conversion branch from e227820 to afbfc7a Compare April 21, 2019 23:49
@seamuslee001 seamuslee001 force-pushed the pledge_dates_contribution_form_conversion branch from afbfc7a to b59a905 Compare April 22, 2019 04:53
@eileenmcnaughton
Copy link
Contributor

I tested this - saving a fixed date backoffice and also allowing front end date edit. I noticed a couple of odd things on the form - but unrelated to this - seems to work well

@eileenmcnaughton eileenmcnaughton merged commit c1c1e89 into civicrm:master Apr 22, 2019
@eileenmcnaughton eileenmcnaughton deleted the pledge_dates_contribution_form_conversion branch April 22, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants