Skip to content

Fixed auto populate of contact refrence field on membership signup form #14077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2019

Conversation

pradpnayak
Copy link
Contributor

Overview

A brief description of the pull request. Try to keep it non-technical.

Before

Before

After

After

Technical Details

The code still used old method of setting contact reference field by default. When contact reference field was changed in core to use Select2 i guess we missed to remove the code from here.

@civibot
Copy link

civibot bot commented Apr 17, 2019

(Standard links)

@civibot civibot bot added the master label Apr 17, 2019
@adevapp
Copy link

adevapp commented Apr 18, 2019

The patch worked for me. I was able to signup and then renew (where the contact reference field was already present) a membership without error.

@pradpnayak
Copy link
Contributor Author

@adam-devapp thanks for QA'ing.

@colemanw
Copy link
Member

Code makes sense. Merging based on code review & user testing.

@colemanw colemanw merged commit 85a1be1 into civicrm:master Apr 20, 2019
@pradpnayak pradpnayak deleted the AutoComplete branch March 23, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants