[REF] cleanup input parameters on extracted function #14050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
As part of a tidy up of this function I am removing as an input parameter & getting it from a function. Unit testing added in testAddressWithCustomData to ensure custom data is still imported. Additional related tests are in that function. This is preliminary to fixing primary handling & related test for phone & email import - and to tidying up general mess in this function
eileenmcnaughton
force-pushed
the
import
branch
from
fcbd2ac to
0b3f2e4
Compare
|
Code looks good & tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code cleanup & add tests - part of bigger fix #14043
Before
$fields param required to be passed in to extracted function
After
$fields param is a class property accessed by a function. Test added
Technical Details
I had some concern about the weird handling custom fields so I added a test & moved the handling to a less mystical place
Comments