Switch to using ContributionRecur.cancel api from CancelSubscription form #14033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form The function cancelRecurContribution is only called from the form ant from the api. This makes it so the form uses the api, which we have started to add unit testing to. Follow ing this we can use the api for transaction handling and move more of the form logic into the api, making it available to others & allowing us to better move to a new form layer later without as much logic in the forms
|
(Standard links)
|
|
Switching to API which calls exactly the same thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This makes it so the form uses the api, which we have started to add unit testing to. Following this we can use the api for transaction handling and move more of the form logic into
the api, making it available to others & allowing us to better move to a new form layer later
without as much logic in the forms
Before
No noticeable change - code consolidation only
After
No noticeable change - code consolidation only
Technical Details
The function cancelRecurContribution is only called from the form and from the api.
I did some preliminary cleanup on the api & added a unit test in a previous PR to prepare for this
Comments