-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(NFC) Convert files to use linux line endings not windows #12531
Conversation
(Standard links)
|
I would have put it against master rather than the rc but I agree it's whitespace only & ok to merge @MiyaNoctem looks like you submitted the wrong endings? You might need to do some config? |
Hmm, a few years ago I tried tackling this problem and came across
And that gave me pause... |
@colemanw i'll revert out the change with IIF.tpl for the moment in that case |
1982ca2
to
ed28afa
Compare
It's too bad because otherwise there's a global variable we can set in git that will force all line endings to a standard. Just need to somehow verify that it's safe to do so on that |
Jenkins re test this please |
@civicrm-builder re test this please |
Overview
After noticing
CRM/Contribute/Page/ContributionRecurPayments.php
was a new file in dos line endings in 5.3 i went and found these other files that were also in dos line endings so fixing them. You should see that there is no function change by adding ?w=1 onto the end of the PR URLBefore
Dos line endings used
After
Linux line endings used
ping @eileenmcnaughton @colemanw @totten