dev/core/#/258 Fix message update routine.

[eileenmcnaughton]

Overview

5.4 unreleased regression - customised message templates being overwritten

https://lab.civicrm.org/dev/core/issues/258

Before

1. customise Contributions - Receipt (on-line) on a 5.3 install
2. upgrade to 5.4
3. note the customised msg_template is updated (and the reserved one is)

After

1. customise Contributions - Receipt (on-line) on a 5.3 install
2. upgrade to 5.4
3. note the customised msg_template is not updated (but the reserved one is)

Technical Details

The test class was misnamed leading to it being deemed to be 'working' when it was not actually running :-(. Other changes are because further templates were added to the 5.4 update after this

Comments

For background prior to 5.4 we didn't ship the xml directory and updates to message templates required a lot of work for the reviewer as the tpl was copied to the install dir where the diff could not be easily viewed. Unfortunately the new mechanism had a bug

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[homotechsual]

I've tested this out today, starting with Civi 5.3 customising the tpl, updating to 5.4 and confirming that the tpl is updated then reverting and updating to 5.4 with the PR applied and confirming that the customised TPL is no longer updated.

@eileenmcnaughton this works as described.

[eileenmcnaughton]

Huge thanks @MikeyMJCO