dev/core#249 Fix crash when performing export all contacts from search

[mattwire]

Overview

Regression since #12341, #12349, related to #12320.

Error: undefined function getContactIds()

To reproduce:

1. Do an empty search
2. Select all contacts
3. Choose "Export" from the task list
4. Export the default fields

Before

Crash.

After

Export works again.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

A fix for this should target 5.4 (RC) because the regression appears in the RC.

When testing patches here, we need to check both:

1. Export contacts (Ex: Search for "Jerome". Select all contacts. In the task-list, choose to export.)
2. Batch update (Ex: Search for "Jerome". Select all contacts. In the task-list, choose to update multiple.)

With this patch, it fixes 1 but breaks 2. :(

[totten]

@mattwire posted a revision here along with some explanatory comments on Mattermost.

I think part of the issue here is the introduction of the Core_Form_Task classes has required some changes to class inheritance etc. And in particular, getContactIds() is no longer part of the class being called.

This does smell like a better theory of the problem (although I still don't claim to fully understand what we're juggling around). In any event, the following use-cases are passing r-run with the lastest 094208c:

• Search for "Jerome".
  • Select all. Export. ==> Observe same 3 exported 👍
  • Select all. Update multiple. ==> Observe same 3 available for update 👍 (Also, make some changes and observe they work. 👍)
• Search for all contacts
  • Select all. Export. => Observe all 203 exported. 👍
  • Select four arbitrary contacts. Export. => Observe all 4 exported. 👍
• Search for all contributions.
  • Select all. Export. => Observe all 93 exported. 👍

@mattwire could you update to target 5.4?

[seamuslee001]

Given @totten's comments i have added the merge ready label, noting that the target of the PR needs to change to be 5.4, ping also @lcdservices Brian you may want to try applying this as well and testing it.

[seamuslee001]

Jenkins re test this please

[mattwire]

Rebased against 5.4

[seamuslee001]

(CiviCRM Review Template WORD-1.1)

• (r-explain) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass tested by myself and Tim and the outcome is as expected
• (r-user) Pass
• (r-tech) Pass